RegisterAsyncJsObject managed methods can now return arrays of structs #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A technical description please This |
amaitland
reviewed
Mar 10, 2017
CefSharp.Example/AsyncBoundObject.cs
Outdated
| @@ -33,5 +37,12 @@ public void DoSomething() | |||
| { | |||
| Thread.Sleep(1000); | |||
| } | |||
|
|
|||
| public JsObject[] ObjectArray(string name) { | |||
There was a problem hiding this comment.
Formatting please, braces on `new lines, be consistent with other
amaitland
reviewed
Mar 10, 2017
CefSharp.Example/AsyncBoundObject.cs
Outdated
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| namespace CefSharp.Example | |||
| { | |||
| public struct JsObject { | |||
amaitland
reviewed
Mar 10, 2017
| @@ -82,11 +82,21 @@ | |||
| writeAsyncResult(call, end); | |||
| }); | |||
| } | |||
|
|
|||
| function asyncObjectArray() { | |||
amaitland
reviewed
Mar 10, 2017
|
|
||
| asyncError(); | ||
| asyncDivOk(); | ||
| asyncDivFail(); | ||
| asyncDoSomething(); | ||
| asyncHello(); |
There was a problem hiding this comment.
Is there an asyncHello method?
joaompneves
changed the title
amaitland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
It was not possible to call .Net methods from JS that return arrays of structs.
Fix:
IsComplexType from JavascriptObjectRepository returns false for arrays.
Notes:
This PR requires 1979